Redirect only GLib loggers to Journal #5962
Conversation
Previously we redirected all output from the main Anaconda process to Journal to avoid GTK log messages (as GTK runs in the main process) from spamming TTY. Turns out this broke a couple things, such as the shell prompt in rescue mode. So drop the wholesale process output redirection and instead just redirect (hopefully) all GLib based loggers (used by GTK) to Journal. Related: RHEL-58834
|
Hello @M4rtinK! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
So this seems to work well enough: A couple notes:
|
|
/kickstart-test --testtype smoke |
| @@ -169,6 +169,7 @@ def setup_environment(): | |||
| if "EDITOR" not in os.environ and os.path.isfile("/etc/profile.d/nano-default-editor.sh"): | |||
| os.environ["EDITOR"] = "/usr/bin/nano" | |||
|
|
|||
|
|
|||
| # Redirect all stderr messages from process to journal | ||
| self.stderrToJournal() | ||
| # Redirect GLib logging (eq. GTK) to Journal | ||
| self.redirect_glib_logging_to_journal() |
There was a problem hiding this comment.
s/eq./e.g.,/
looks like this file uses camelCase for function names? All of your new functions seem to use underscores
| def stderrToJournal(self): | ||
| """Print all stderr messages from Anaconda to journal instead. | ||
| def redirect_glib_logging_to_journal(self): | ||
| """Redirect GLib based library logging to Journal. |
There was a problem hiding this comment.
it's usually called "the journal" not "Journal", but I guess it doesn't really matter
|
|
||
| Some GLib based libraries (such as GTK) do direct their | ||
| sometimes quite verbose log messages to the output of the | ||
| proces in which they are running. In the Anaconda case, |
| sometimes quite verbose log messages to the output of the | ||
| proces in which they are running. In the Anaconda case, | ||
| this creates issues with TTY1 being spammed with those | ||
| messages, with important content (such RDP connection intructions) |
There was a problem hiding this comment.
s/such RDP connection intructions/such as RDP connection instructions/
| # create functions that convert the messages comming | ||
| # from GLib into something that fits to the PYthon logging format |
There was a problem hiding this comment.
s/comming/ s/PYthon/python/
It's not actually a python logging format but the anaconda logging format right?
| self.anaconda_logger.debug("GLib: %s", message) | ||
| return GLib.LogWriterOutput.HANDLED | ||
|
|
||
| # redirect GLib loug output vit the functions |
| return GLib.LogWriterOutput.HANDLED | ||
|
|
||
| # redirect GLib loug output vit the functions | ||
| GLib.log_set_handler(None, GLib.LogLevelFlags.LEVEL_MASK, log_adapter, None) |
There was a problem hiding this comment.
i wonder if it would be clearer to give the individual log levels instead of using the mask wholesale. doesn't really matter, but food for thought.
Previously we redirected all output from the main Anaconda process to Journal to avoid GTK log messages (as GTK runs in the main process) from spamming TTY. Turns out this broke a couple things, such as the shell prompt in rescue mode.
So drop the wholesale process output redirection and instead just redirect (hopefully) all GLib based loggers (used by GTK) to Journal.
Related: RHEL-58834